[PATCH] Missing v4l2_prio_close in radio_release

From: Udo A. Steinberg
Date: Fri Jan 02 2009 - 01:06:29 EST


The radio_release function of the BTTV driver is missing a call to
v4l2_prio_close. As a result, after the radio device has been opened at
least once (e.g., by HAL during bootup), v4l2_priority will never drop below
V4L2_PRIORITY_INTERACTIVE again. With the following patch against 2.6.28,
applications that run with V4L2_PRIORITY_BACKGROUND are able to open devices
again. Previous Linux versions are affected as well.


Signed-off-by: Udo Steinberg <udo@xxxxxxxxxxxxxx>

--- linux-2.6.28/drivers/media/video/bt8xx/bttv-driver.c 2008-10-10 00:13:53.000000000 +0200
+++ linux-2.6.28/drivers/media/video/bt8xx/bttv-driver.new 2009-01-02 06:23:38.000000000 +0100
@@ -3473,6 +3474,7 @@
struct bttv *btv = fh->btv;
struct rds_command cmd;

+ v4l2_prio_close(&btv->prio,&fh->prio);
file->private_data = NULL;
kfree(fh);

Attachment: signature.asc
Description: PGP signature