Re: [PATCH 01/15] ACPI: create kernel/acpi/

[Sam Ravnborg]

> diff --git a/kernel/acpi/Makefile b/kernel/acpi/Makefile
> new file mode 100644
> index 0000000..92a1f94
> --- /dev/null
> +++ b/kernel/acpi/Makefile
> @@ -0,0 +1,26 @@
> +#
> +# Makefile for the Linux/ACPI
> +#
> +
> +export ACPI_CFLAGS
> +

Why is ACPI_CFLAGS exported?
> +ACPI_CFLAGS	:= -Os
> +
> +ifdef CONFIG_ACPI_DEBUG
> +  ACPI_CFLAGS	+= -DACPI_DEBUG_OUTPUT
> +endif
> +
> +EXTRA_CFLAGS	+= $(ACPI_CFLAGS)
A better way:

ccflags-$(CONFIG_ACPI_DEBUG) := -DACPI_DEBUG_OUTPUT

Note: EXTRA_CFLAGS is deprecated in favour of ccflags-y.

> +export ACPI_CFLAGS
> +
> +ACPI_CFLAGS	:= -Os
> +
> +ifdef CONFIG_ACPI_DEBUG
> +  ACPI_CFLAGS	+= -DACPI_DEBUG_OUTPUT
> +endif
> +
> +EXTRA_CFLAGS	+= $(ACPI_CFLAGS)

Same construct - see above.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/