Re: [PATCH] minix: fix add link - wrong position calculation

[Nick Piggin]

On Tue, Dec 30, 2008 at 03:32:30PM -0800, Andrew Morton wrote:
> On Mon, 29 Dec 2008 02:25:50 +0300
> Evgeniy Dushistov <dushistov@xxxxxxx> wrote:
> 
> > This patch fixes add link method.
> > Position in directory was calculated in wrong way.
> > 
> > Signed-off-by: Evgeniy Dushistov <dushistov@xxxxxxx>
> > ---
> >  fs/minix/dir.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/fs/minix/dir.c b/fs/minix/dir.c
> > index f704338..4b603b7 100644
> > --- a/fs/minix/dir.c
> > +++ b/fs/minix/dir.c
> > @@ -280,7 +280,7 @@ int minix_add_link(struct dentry *dentry, struct inode *inode)
> >  	return -EINVAL;
> >  
> >  got_it:
> > -	pos = (page->index >> PAGE_CACHE_SHIFT) + p - (char*)page_address(page);
> > +	pos = page_offset(page) + p - (char*)page_address(page);
> >  	err = __minix_write_begin(NULL, page->mapping, pos, sbi->s_dirsize,
> >  					AOP_FLAG_UNINTERRUPTIBLE, &page, NULL);
> >  	if (err)
> 
> Well that's cute.  Seems that we broke it over a year ago:
> 
> commit 4a66af9eaa9531372cfcb9e20103ed147c729ff9
> Author:     Nick Piggin <npiggin@xxxxxxx>
> AuthorDate: Tue Oct 16 01:25:21 2007 -0700
> Commit:     Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxxxxxxxx>
> CommitDate: Tue Oct 16 09:42:57 2007 -0700
> 
>     minixfs: convert to new aops
> 
> Is minixfs getting THAT little use, or is this bustage more subtle
> than it appears?

Not getting used, I'd suspect (although I definitely have used it -- I
converted it to large block size for testing fsblock, probably I didn't
test softlinks).

But anyway I think it is still useful as a primer for ext2? Probably there
are quite a lot of other filesystems that are less useful than minix ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/