Re: [PATCH 1/2] RCU: Don't include unnecessary headers, allowkmemtrace w/ tracepoints.

[Eduard - Gabriel Munteanu]

On Tue, Dec 30, 2008 at 08:53:37AM +0100, Ingo Molnar wrote:
> hm, there are quite a few such dependencies it appears, for example:
> 
> In file included from init/do_mounts_initrd.c:4:
> include/linux/fs.h: In function 'alloc_secdata':
> include/linux/fs.h:2214: error: implicit declaration of function 'get_zeroed_page'
> include/linux/fs.h:2214: error: 'GFP_KERNEL' undeclared (first use in this function)
> include/linux/fs.h:2214: error: (Each undeclared identifier is reported only once
> include/linux/fs.h:2214: error: for each function it appears in.)
> include/linux/fs.h: In function 'free_secdata':
> include/linux/fs.h:2219: error: implicit declaration of function 
> 'free_page'
> In file included from include/linux/slab.h:13,
>                  from include/linux/percpu.h:6,
>                  from include/linux/percpu_counter.h:14,
>                  from include/linux/ext2_fs_sb.h:21,
>                  from include/linux/ext2_fs.h:70,
>                  from init/do_mounts_initrd.c:6:
> 
> config attached.
> 
> 	Ingo

Hm, that's weird, I was also testing on a 2.6.28-based tree. And I don't
see any reference to RCU headers in this error message. My guess is some
code assumes a certain header provides some definitions it isn't
required to.

I'll checkout your tree and have a look.


	Eduard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/