Re: [PATCH] sched: sched.c declare variables before they get used

From: Ingo Molnar
Date: Tue Dec 30 2008 - 01:43:37 EST



* Jaswinder Singh Rajput <jaswinder@xxxxxxxxxxxxx> wrote:

> Impact: cleanup, avoid sparse warnings
>
> In linux/sched.h moved out sysctl_sched_latency,
> sysctl_sched_min_granularity, sysctl_sched_wakeup_granularity,
> sysctl_sched_shares_ratelimit and sysctl_sched_shares_thresh from #ifdef
> CONFIG_SCHED_DEBUG as these variables are common for both.
>
> Fixes these sparse warnings:
> kernel/sched.c:825:14: warning: symbol 'sysctl_sched_shares_ratelimit' was not declared. Should it be static?
> kernel/sched.c:832:14: warning: symbol 'sysctl_sched_shares_thresh' was not declared. Should it be static?
> kernel/sched_fair.c:37:14: warning: symbol 'sysctl_sched_latency' was not declared. Should it be static?
> kernel/sched_fair.c:43:14: warning: symbol 'sysctl_sched_min_granularity' was not declared. Should it be static?
> kernel/sched_fair.c:72:14: warning: symbol 'sysctl_sched_wakeup_granularity' was not declared. Should it be static?
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
> ---
> include/linux/sched.h | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)

applied to tip/sched/cleanups, thanks!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/