Re: [PATCH] move arch/x86/pci/pci.h toarch/x86/include/asm/pci_x86.h

From: Alexey Dobriyan
Date: Mon Dec 29 2008 - 03:44:00 EST


On Mon, Dec 29, 2008 at 01:28:58PM +0530, Jaswinder Singh Rajput wrote:
> On Mon, 2008-12-29 at 09:57 +0300, Alexey Dobriyan wrote:
> > On Sat, Dec 27, 2008 at 06:32:28PM +0530, Jaswinder Singh Rajput wrote:
> > > Impact: cleanup, arch/x86/pci/pci.h -> arch/x86/include/asm/pci_x86.h
> >
> > And this is done for what?
>
> Don't you think ïarch/x86/pci/pci.h looks ugly it should be in
> arch/x86/incluse/asm directory ?

It was

#include "../pci/pci.h"

which can look ugly, not full path.

Anyway, you want to put you question into changelog?

> It was suggested by Ingo :
> http://marc.info/?l=linux-kernel&m=123037395221921&w=2
>
> I think Ingo will have more valid reasons to satisfy your curiousity ;-)

So you don't actually have an opinion? Why are you sending patch then?

> could you send another patch that moves arch/x86/pci/pci.h to
> arch/x86/include/asm/pci_x86.h
^^^ ^^^
Or should it be arch/x86/include/asm/pci.h ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/