[PATCH] kbuild, sparseirq: work around GCC bug with __weak aliases

From: Ingo Molnar
Date: Fri Dec 26 2008 - 08:44:46 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

> > I recall David Howells had a similar issue with the bootparamter patch
> > set. The workaround he used was to add a barrier(); call in the weak
> > function to avoid the inline.
>
> could we add some extra attribute to __weak that would have a similar
> effect? Something like __attribute__((noinline)), or something silly
> like __attribute__((deprecated)) - just to keep gcc from screwing up
> __weak functions? Perhaps adding a section attribute would have a
> similar effect? (putting weak definitions into an extra section is
> probably helpful anyway)

I've applied the patch below to tip/irq/sparseirq - could someone with an
affected GCC version please check whether this solves the crash?

Ingo

------------------->