Re: [PATCH 2/2 -tip] irq: kstat_incr_irqs_this_cpu only needs oneparameter

[Wang Chen]

Ingo Molnar said the following on 2008-12-26 17:18:
> * Wang Chen <wangchen@xxxxxxxxxxxxxx> wrote:
> 
>> desc is useless for kstat_incr_irqs_this_cpu.
>>
>> Signed-off-by: Wang Chen <wangchen@xxxxxxxxxxxxxx>
>> ---
>>  arch/x86/kernel/visws_quirks.c |    2 +-
>>  arch/x86/xen/spinlock.c        |    2 +-
>>  include/linux/kernel_stat.h    |    3 +--
>>  kernel/irq/chip.c              |   10 +++++-----
>>  kernel/irq/handle.c            |    4 ++--
>>  5 files changed, 10 insertions(+), 11 deletions(-)
>>
>> diff --git a/arch/x86/kernel/visws_quirks.c b/arch/x86/kernel/visws_quirks.c
>> index 0c9667f..bd37460 100644
>> --- a/arch/x86/kernel/visws_quirks.c
>> +++ b/arch/x86/kernel/visws_quirks.c
>> @@ -633,7 +633,7 @@ static irqreturn_t piix4_master_intr(int irq, void *dev_id)
>>  	/*
>>  	 * handle this 'virtual interrupt' as a Cobalt one now.
>>  	 */
>> -	kstat_incr_irqs_this_cpu(realirq, desc);
>> +	kstat_incr_irqs_this_cpu(realirq);
>>  
>>  	if (likely(desc->action != NULL))
>>  		handle_IRQ_event(realirq, desc->action);
> 
> 'desc' is needed in the sparseirq model:
> 
> #define kstat_incr_irqs_this_cpu(irqno, DESC) \
>         ((DESC)->kstat_irqs[smp_processor_id()]++)
> 
> See:
> 
>  http://people.redhat.com/mingo/tip.git/README
> 
> 	Ingo

Sorry, I didn't checkout that branch.
Please ignore this one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/