Re: [PATCH for -tip] proc: remove ifdef CONFIG_SPARSE_IRQ fromstat.c

From: Ingo Molnar
Date: Thu Dec 25 2008 - 05:59:40 EST



* KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:

>
> I confirmed by alpha cross compiler.
>
> ==
> Subject: [PATCH] proc: remove ifdef CONFIG_SPARSE_IRQ from stat.c
> Impact: cleanup
>
> commit 240d367b4e6c6e3c5075e034db14dba60a6f5fa7 has a bit strange analysis.
> The fact is, irq_desc() can be used old architecuture too.
> but old code don't include <linux/irq.h>.
>
> right fixing is here.

> +#include <linux/irq.h>

looks good, but linux/irq.h cannot be included on all architectures. (for
example s390 has no notion of 'hardirqs'). But we created linux/irqnr.h
for this purpose - so including that should work better.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/