Re: [PATCH] sh: maple: Robust checking for errors on maple keyboard initialisation

From: Mike Frysinger
Date: Wed Dec 24 2008 - 11:14:52 EST


On Saturday 20 December 2008 13:25:27 Adrian McMenamin wrote:
> - maple_set_drvdata(mdev, NULL);
> - return error;
> +fail:
> + return -error;

same comment as for the joystick driver ... it's weird and i'm pretty sure
incorrect due to other functions setting error as well as this driver.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.