[PATCH] ext4: annotate unhandled kmem_cache_alloc() error

From: Akinobu Mita
Date: Tue Dec 23 2008 - 05:40:50 EST


kmem_cache_alloc() error in ext4_mb_free_metadata is not handled.
I don't know how to fix it. But I can put BUG_ON to let others
know the problem.

Cc: Theodore Tso <tytso@xxxxxxx>
Cc: adilger@xxxxxxx
Cc: linux-ext4@xxxxxxxxxxxxxxx
Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
---
fs/ext4/mballoc.c | 1 +
1 file changed, 1 insertion(+)

Index: 2.6-rc/fs/ext4/mballoc.c
===================================================================
--- 2.6-rc.orig/fs/ext4/mballoc.c
+++ 2.6-rc/fs/ext4/mballoc.c
@@ -4417,6 +4417,7 @@ ext4_mb_free_metadata(handle_t *handle,
BUG_ON(e4b->bd_buddy_page == NULL);

new_entry = kmem_cache_alloc(ext4_free_ext_cachep, GFP_NOFS);
+ BUG_ON(!new_entry);
new_entry->start_blk = block;
new_entry->group = group;
new_entry->count = count;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/