Re: [PATCH v7 4/8] sched: nominate preferred wakeup cpu

From: Ingo Molnar
Date: Sat Dec 20 2008 - 02:55:30 EST



* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Sat, 20 Dec 2008 10:06:38 +0530 Vaidyanathan Srinivasan <svaidy@xxxxxxxxxxxxxxxxxx> wrote:
>
> > >
> > > kernel/sched.c: In function 'schedule':
> > > kernel/sched.c:3679: warning: 'active_balance' may be used uninitialized in this function
> > >
> > > This warning is correct - the code is buggy.
> >
> > Yes this is my code bug. I did not see the warning in sched.c. Is
> > there any build option that I need to pass in order to get -Wall
> > effect?
>
> That was just with plain old kbuild: `make allmodconfig;make'.
>
> That warning was produced by gcc-4.0.2. If you're using something more
> recent then gcc has regressed.

hm, it didnt trigger here with gcc 4.3 - and the condition is serious.
I've applied the fix, thanks guys!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/