Re: [PATCH, v5] 9p: don't print IS_ERR strings

[Eric Van Hensbergen]

NAK - the print is a debug to mark function entry when debugging is on
-- it is not intended to show only success.  If an erroneous s will
cause the print to break then perhaps it should be parameterized, but
the entire print shouldn't be pushed inside the if statement.

            -eric


On Fri, Dec 19, 2008 at 2:47 PM, Duane Griffin <duaneg@xxxxxxxxx> wrote:
> Move the printk inside the !IS_ERR test.
>
> Cc: Eric Van Hensbergen <ericvh@xxxxxxxxx>
> Cc: Ron Minnich <rminnich@xxxxxxxxxx>
> Cc: Latchesar Ionkov <lucho@xxxxxxxxxx>
> Cc: v9fs-developer@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Duane Griffin <duaneg@xxxxxxxxx>
> ---
>
> Unchanged from original version.
>
>  fs/9p/vfs_inode.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
> index 8fddfe8..c50d555 100644
> --- a/fs/9p/vfs_inode.c
> +++ b/fs/9p/vfs_inode.c
> @@ -1022,9 +1022,10 @@ v9fs_vfs_put_link(struct dentry *dentry, struct nameidata *nd, void *p)
>  {
>        char *s = nd_get_link(nd);
>
> -       P9_DPRINTK(P9_DEBUG_VFS, " %s %s\n", dentry->d_name.name, s);
> -       if (!IS_ERR(s))
> +       if (!IS_ERR(s)) {
> +               P9_DPRINTK(P9_DEBUG_VFS, " %s %s\n", dentry->d_name.name, s);
>                __putname(s);
> +       }
>  }
>
>  /**
> --
> 1.6.0.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/