Re: [patch 1/7] ftrace: fix task state printout

From: Thomas Gleixner
Date: Fri Dec 19 2008 - 16:41:27 EST


On Fri, 19 Dec 2008, Frédéric Weisbecker wrote:
> Hi Thomas,
>
> 2008/12/19 Thomas Gleixner <tglx@xxxxxxxxxxxxx>:
> > Impact: tracer task state decoding is wrong, size check is buggy
> >
> > The tracing code has interesting varieties of printing out task state.
> > Unfortunalely only one of the instances is correct as it copies the
> > code from sched.c:sched_show_task(). The others are plain wrong as
> > they treatthe bitfield as an integer offset into the character
> > array. Also the size check of the character array is wrong as it
> > includes the trailing \0.
> >
> > Use a common state decoder inline which does the Right Thing.
> >
> > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>
>
> You've already sent it out. It has been applied on -tip :-)

Yep, but these patches are against 2.6.24.7-rt24 as noted in the
subject line of patch 0/7 :)

Thanks,

tglx