Re: [PATCH] net: Remove a noisy printk

From: Rusty Russell
Date: Thu Dec 18 2008 - 20:22:22 EST


On Monday 15 December 2008 06:33:53 Dave Jones wrote:
> On Sun, Dec 14, 2008 at 06:09:17PM +0100, Jozsef Kadlecsik wrote:
> > In a >normal< system one usually does not use raw sockets. So if a root
> > process do use raw socket, at least netfilter sends a notification and
> > there's a chance that someone take notice it by checking the kernel logs.
>
> 'normal' systems are irrelevant here. This message is triggerable remotely.

I don't think it can be. This is for truncated locally-generated outgoing
packets, which can only happen when root is playing with raw sockets.

As you can probably tell, I was the one who wrote this printk :) IMHO,
one reasonable complaint is sufficient to have it removed, so just remove
it. If anyone thinks it's valuable, put a static counter < 5 around it
and add pid/comm info.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/