Re: [PATCH] x86: sigframe.h: add guard macro

[Ingo Molnar]

* Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx> wrote:

> From: Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>
> 
> Impact: cleanup
> 
> Add missing guard macro _ASM_X86_SIGFRAME_H.
> 
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>
> ---
> I forgot include guard:)
> 
>  arch/x86/include/asm/sigframe.h |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

applied, thanks!

It didnt matter in practice yet, because all uses of sigframe.h were 
single-instance and were done in flat .c files, not in .h files:

 ./arch/x86/kernel/asm-offsets_32.c:#include "sigframe.h"
 ./arch/x86/kernel/signal_32.c:#include "sigframe.h"
 ./arch/x86/kernel/signal_64.c:#include "sigframe.h"
 ./arch/x86/ia32/ia32_signal.c:	struct _fpstate_ia32 fpstate_unused; /* look at kernel/sigframe.h */

but indeed it's better to have this fixed - just in case we put sigframe.h 
into an include file.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/