Re: [rfc git patch] union directory

[Miklos Szeredi]

On Wed, 17 Dec 2008, Ian Kent wrote:
> On Fri, 28 Nov 2008, Miklos Szeredi wrote:
> 
> > I've been doing some small fixing/cleanup work on the union directory
> > patches by Jan, and just noticed there's a thread about the union
> > mounts on LKML, so I thought publicizing won't hurt.
> > 
> > It's still a work in progress, notably the readdir code currently only
> > works on a few specific filesystem types.
> > 
> > Git tree is here:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git union-dir
> 
> I'm confused?
> 
> This doesn't look like the complete set of Jan Blunks union mount
> patches.  Am I mistaken?

You're not mistaken, this is not the original patch set, but a reduced
one (also by Jan), further reduced and cleaned up by me.

The original patch set implemented deep unioning of directory trees.
This one implements only unioning of the mount's top level directory.

> But this also made me think about the issues surrounding whiteout support 
> as having to add per-file system support for such things is bound to lead 
> to a maintenance headache. So why not a well defined modular interface 
> layer that includes these bits and is also responsible for context 
> persistence, independent of file system?

I don't think such a layer is in the scope of this patch set.  It may
be a nice thing, but it will almost certainly be implemented in a
filesystem, not in the VFS.  Union mounts, as opposed to unionfs and
its ilk, are supposed to be very lightweight.

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/