Re: [PATCH] x86: traps.c declare functions before they get used

[Ingo Molnar]

* Jaswinder Singh <jaswinderlinux@xxxxxxxxx> wrote:

> Hello Ingo,
> 
> On Wed, Dec 17, 2008 at 1:49 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
> >> +#ifndef CONFIG_MATH_EMULATION
> >>  asmlinkage void math_emulate(long);
> >>  #endif
> >
> > uhm, shouldnt that #ifndef CONFIG_MATH_EMULATION be #ifdef
> > CONFIG_MATH_EMULATION?
> >
> 
> Sorry, but it seems correct to me in traps case will be opposite.
> 
> If someone tries to access math_emulate() and MATH_EMULATION is not 
> defined then he will be trapped ;-)

you should build-test your patch with MATH_EMULATION enabled.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/