Re: [RFC] globmatch() helper function

[Steven Rostedt]

On Thu, 2008-12-18 at 01:22 +0900, Tejun Heo wrote:
> Hello,
> 
> George Spelvin wrote:
> > Do people think that would be, on balance, better?  It would be plenty
> > good enough for the blacklist application.
> 
> Just pass a depth parameter and trigger WARN_ON() and return -EINVAL
> when it exceeds ten.  It's a five minute change and should be enough
> for kernel usages.

If this is ever expected to be used by userspace, I would not include
the WARN_ON. If this is a generic function, then I'll include in in
ftrace as well, and that takes userspace input. The last thing I want is
a DoS because of printk's to the serial console because some userspace
app is constantly writing bad patterns to this file.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/