Re: [PATCH, RESEND2] getrusage: fill ru_maxrss value

[Jiri Pirko]

On Wed, 17 Dec 2008 19:48:44 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:

> > (updated)
> > 
> > This patch makes ->ru_maxrss value in struct rusage filled accordingly to
> > rss hiwater mark. This struct is filled as a parameter to
> > getrusage syscall. ->ru_maxrss value is set to pages which might be correct
> > as "time" application converts it to KBs.
> 
> Why?
> if kernel convert to KB, glibc don't need any change.
Where exactly glibc is working with this as KBs? I can't find that place.

I looked into sources of time util and maxrss is showed this way:
fprintf (fp, "%lu", ptok ((UL) resp->ru.ru_maxrss));
ptok() actually does pages_to_KB conversion. If we convert to KB in
kernel, this code must be changed.
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/