RE: [Patch 3/3] via-sdmmc: via-sdmmc.h

From: JosephChan
Date: Wed Dec 17 2008 - 06:14:20 EST


> >
>
> The order of your patches is reversed, you add the
> Kconfig/Makefile changes last so that the tree stays
> 'bisectable', i.e. you don't have a broken build in the
> middle between your patches.
>
> Since your header file is not an interface but only used in a
> single source file, I would also suggest merging it into the
> main via-sdmmc.c file, add changing Kconfig/Makefile in the
> same patch.
>
> Arnd <><
>

Tks, I'll notice this next time.
¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶Ÿÿà -»+ƒùdš_