Re: [PATCH 7/15] sanitize AUDIT_MQ_SENDRECV

[Andrew Morton]

On Wed, 17 Dec 2008 05:12:10 +0000 Al Viro <viro@xxxxxxxxxxxxxxxx> wrote:

> 
> * logging the original value of *msg_prio in mq_timedreceive(2)
>   is insane - the argument is write-only (i.e. syscall always
>   ignores the original value and only overwrites it).
> * merge __audit_mq_timed{send,receive}
> * don't do copy_from_user() twice
> * don't mess with allocations in auditsc part
> * ... and don't bother checking !audit_enabled and !context in there -
>   we'd already checked for audit_dummy_context().
> 
> ...
>
> +		if (copy_from_user(&ts, u_abs_timeout, 
> +					sizeof(struct timespec)))

Well that's odd.  afacit timespec has different sizes on 32-bit and
64-bit userspace.

But the old audit code did this copy too, and it presumably worked.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/