Re: [PATCH] tracing/ftrace: use preempt_enable_no_resched_notracein ring_buffer_time_stamp()

[Ingo Molnar]

* Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> Impact: prevent a trace recursion
> 
> After some tests with function graph tracer under x86-32, I saw some recursions
> caused by ring_buffer_time_stamp() that calls preempt_enable_no_notrace() which
> calls preempt_schedule() which is traced itself.
> 
> This patch re-enables preemption without rescheduling.
> 
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> ---
>  kernel/trace/ring_buffer.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

applied to tip/tracing/ftrace, thanks Frederic!

Does this explain+fix the weird crashes/reboots you were seeing?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/