Re: Impact:
From: David Miller
Date: Tue Dec 16 2008 - 01:38:19 EST
From: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Date: Tue, 16 Dec 2008 04:10:39 +0300
> On Mon, Dec 15, 2008 at 12:20:19AM -0800, David Miller wrote:
> > > update rwlock initialization for nat_table
> > >
> > > Impact: clean up
> > >
> > > The commit e099a173573ce1ba171092aee7bb3c72ea686e59
> > > (netfilter: netns nat: per-netns NAT table) renamed the
> > > nat_table from __nat_table to nat_table without updating the
> > > __RW_LOCK_UNLOCKED(__nat_table.lock).
> > >
> > > Signed-off-by: Steven Rostedt <srostedt@xxxxxxxxxx>
> >
> > Applied to net-2.6, thanks Steven.
> >
> > As Andrew mentioned this is a bug (albeit a "nano-bug" as you
> > called it :-) so I removed the Impact line in the commit
> > message when applying this.
>
> Speaking of Impact: lines, is this a new fashion or what?
I don't know what it is, but I find them pointless.
Just provide a proper verbose commit message and be done with it.
At the rate we're going we'll soon have commit messages like:
--------------------
Impact: Crashes kernel
Cause: Race between timer and workqueue
Implementation: ...
--------------------
I mean, spare me...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/