Re: [PATCH, take2] percpu_counter: FBC_BATCH might be too big

From: Andrew Morton
Date: Sun Dec 07 2008 - 23:33:19 EST

On Sun, 07 Dec 2008 19:30:10 +0100 Eric Dumazet <dada1@xxxxxxxxxxxxx> wrote:

> >
> > Do
> >
> > $EDITOR $(grep -l hotcpu_notifier */*.c)
> >
> > and you'll see lots of code gets it right, and lots of code gets it wrong.
> I see nothing interesting, I must be blind.
> lib/percpu_counter.c: In function 'percpu_counter_startup':
> lib/percpu_counter.c:158: error: 'percpu_counter_hotcpu_callback' undeclared (first use in this function)
> lib/percpu_counter.c:158: error: (Each undeclared identifier is reported only once
> lib/percpu_counter.c:158: error: for each function it appears in.)
> make[1]: *** [lib/percpu_counter.o] Error 1

Perhaps you still had percpu_counter_hotcpu_callback inside #ifdef.

That a look at kernel/workqueue.c, fs/buffer.c. No #ifdef CONFIG_HOTPLUG_CPU
needed at all.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at