Re: [PATCH 2/3] PCI: Suspend and resume PCI Express ports withinterrupts disabled

From: Linus Torvalds
Date: Sat Dec 06 2008 - 12:39:17 EST

On Sat, 6 Dec 2008, Rafael J. Wysocki wrote:
> I think it should go through Jesse?

Probably correct. And we want it in -next, so that it can get some testing
even before I open the merge window. Because I hope everybody realizes
that there's no way we're doing this in 2.6.28, and we'll leave the broken
and unreliable suspend.

Because afaik this is not a new bug (I tried to push a patch to do
suspend_late/resume_early for the PCI code a _loong_ time ago, but it
never got merged), and the only reason it showed up as a regression was
almost certainly simply that we've always had this.

IOW, suspend/resume has always been dodgy wrt interrupts, and there's some
luck involved. And your machine just happened to get unlucky.

I'd love to fix this in 2.6.28, but it's just not reasonable - it needs
widespread testing with an early -rc merge. And if it turns out to fix a
lot of machines, and there are no regressions, we can always back-port it


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at