Re: [patch] ohci1394: don't leave interrupts enabled during suspend/resume

From: Stefan Richter
Date: Sat Dec 06 2008 - 11:12:47 EST

Frans Pop wrote:
> On my HP 2510p I get the following in dmesg during near the end of most
> resumes from suspend to RAM:
> irq 19: nobody cared (try booting with the "irqpoll" option)
> Pid: 0, comm: swapper Not tainted 2.6.28-rc7 #67
> Call Trace:
> <IRQ> [<ffffffffa00ee9e1>] ? ohci_irq_handler+0x60/0x7e9 [ohci1394]
> There also seems to be an interrupt storm during suspend/resume when this
> happens:
> 19: 99968 33 IO-APIC-fasteoi ohci1394
> This patch gets rid of both issues and makes the resume as a whole
> significantly faster.

Looks good, thanks. Committed to linux1394-2.6.git.

> I don't actually use firewire, so I cannot test anything other than
> checking dmesg and seeing that there are no changes. With the patch
> I do see a very slow increase of the interrupt count, so the device
> seems active.

Yes, there should be an interrupt every 64 seconds even if no IO is
going through the FireWire controller.

> Please review the patch carefully, especially the error handling.
> The patch is essentially only copy-and-paste work, with checks against
> other drivers and the ohci1394_pci_probe function.

Error handling in ohci1394's suspend method looked dubious already
before your patch...
Stefan Richter
-=====-==--- ==-- --==-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at