Re: [PATCH] crypto: des: fix inverted weak key flag check

From: Jarod Wilson
Date: Fri Dec 05 2008 - 09:51:20 EST

Jarod Wilson wrote:
Based on the fact the testmgr code sets the weak key flag for
vectors with wk = 1, the weak key flag check in des_setkey()
is backwards. Also, add a warning when a weak key is rejected,
otherwise you silently get a bogus result back.

Signed-off-by: Jarod Wilson <jarod@xxxxxxxxxx>

Self-NAK. Due to mail server issues, this might show up before the original...

My understanding of the flag's meaning appears to be backwards, Herbert pointed out that the use of this flag is self-consistent. Also, the printk probably shouldn't be there, the caller should check retval and complain if need be.

Jarod Wilson
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at