Re: [PATCH 1/3] tracing/ftrace: don't insert TRACE_PRINT duringselftests

From: Ingo Molnar
Date: Fri Dec 05 2008 - 08:48:31 EST

* Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> Impact: fix tracer selfstests false results
> After setting a ftrace_printk somewhere in th kernel, I saw the
> Function tracer selftest failing.
> When a selftest occurs, the ring buffer is lurked to see if
> some entries were inserted. But concurrent insertion such as
> ftrace_printk could occured at the same time and could give
> false positive or negative results.
> This patch prevent prevent from TRACE_PRINT entries insertion
> during selftests.
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> ---
> kernel/trace/trace.c | 13 ++++++++++++-
> 1 files changed, 12 insertions(+), 1 deletions(-)

applied to tip/tracing/ftrace, thanks.

I suspect you'll also fix the things Steve pointed out?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at