Re: [trivial] fix missing space in printk

From: Ingo Molnar
Date: Fri Dec 05 2008 - 07:11:20 EST



* Michael Tokarev <mjt@xxxxxxxxxx> wrote:

> Just come across this when booting on an old hw.. Looks somewhat ugly,
> that single missing space ;)
>
> And oh,
>
> Signed-Off-By: Michael Tokarev <mjt@xxxxxxxxxx>
>
> ;)

applied to tip/x86/cleanups.

> --- a/arch/x86/kernel/smpboot.c 2008-10-10 02:13:53.000000000 +0400
> +++ b/arch/x86/kernel/smpboot.c 2008-12-05 14:39:29.608353301 +0300
> @@ -1084,7 +1084,7 @@ static int __init smp_sanity_check(unsig
> #endif
>
> if (!physid_isset(hard_smp_processor_id(), phys_cpu_present_map)) {
> - printk(KERN_WARNING "weird, boot CPU (#%d) not listed"
> + printk(KERN_WARNING "weird, boot CPU (#%d) not listed "
> "by the BIOS.\n", hard_smp_processor_id());

btw., the reason for that bug was the incorrect line break in the middle
of a string - we humans just dont notice a missing space in that context.

So in the final commit i've moved the string to a single line, see it
attached below.

Ingo

--------------->