Re: [PATCH] EXPORTFS: Don't return NULL fromfh_to_dentry()/fh_to_parent()

From: Christoph Hellwig
Date: Fri Dec 05 2008 - 04:41:34 EST

On Fri, Dec 05, 2008 at 09:12:56AM +0000, David Howells wrote:
> Returning NULL from fh_to_dentry() and fh_to_parent() is not permitted, so
> return -ESTALE instead. exportfs_decode_fh() does not check for NULL, but
> will try to dereference it as IS_ERR() does not check for it.
> The generic_fh_to_dentry() and generic_fh_to_parent() functions also no longer
> return NULL, but return -ESTALE instead.
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> Acked-by: J. Bruce Fields <bfields@xxxxxxxxxxxxxx>

Looks good, thanks. Linus, this is regression introduced in 2.6.28 by
me, so please apply.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at