Re: [PATCH] Resurrect IT8172 IDE controller driver

From: Sergei Shtylyov
Date: Thu Dec 04 2008 - 11:17:29 EST


Alan Cox wrote:

I am not sure how to determine if IORDY sampling is supported by a
drive. If I'm reading the code correctly, other drivers only check
that the PIO mode is > 2 (not > 1 as in my driver) -- that seems to be
the case for at least piix.c, siimage.c, and it8213.c.

Old IDE is wrong on this and in fact unless it has changed recently
simply can't cope with and doesn't provide functions for it. A libata

It's not as wrong as you're trying to paint it: ide_get_best_pio_mode() has been here for ages and it have been returning the IORDY setting -- although it actually asks the drive only when auto-tuning the mode, and when being given the explicit mode only tells to use IORDY on modes > 2.

WBR, Sergei
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at