Re: BUG? "Call fasync() functions without the BKL" is racy

[Andi Kleen]

> > I wonder if we need FASYNC at all. This could be gotten implicitely by
> > looking at the fasync_list
>
> Only if socket.

But the helpers used by the character drivers add it too I think.

> Serioulsy, I think the best (partial, yes) fix for now is to restore
> lock_kernel() in setfl() and change ioctl_fioxxx() accordingly.
> At least this protect us from tty too.

For 2.6.28 I agree.

> Not that I think this is very good idea though ;)

The lock bit sounds reasonable.

-Andi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/