Re: [PATCH v2] ext3, ext4: do_split() fix loop, with obvious unsignedwrap

From: Bill Davidsen
Date: Wed Dec 03 2008 - 09:26:32 EST

Bill Davidsen wrote:
I seriously disagree on that, writing it as a for makes it totally clear that the index initialization is part of the loop.
I know, looks funny, not the way we have always done it, not invented here...

Just to be clear, I didn't mean that in any bad way, just that sometimes a new format, even if correct and unambiguous, looks strange to the eye and is not used just because it jars. I still think putting initialization for a loop in the start of the for is defensive programming, perhaps I've had too many bumblers inherit my code.

Bill Davidsen <davidsen@xxxxxxx>
"Woe unto the statesman who makes war without a reason that will still
be valid when the war is over..." Otto von Bismark

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at