Re: [PATCH 2/2 update] misc: Add dell-laptop driver

From: Alan Jenkins
Date: Wed Dec 03 2008 - 07:37:40 EST

Matthew Garrett wrote:
> misc: Add dell-laptop driver
> Add a driver for controling Dell-specific backlight and rfkill interfaces.
> This driver makes use of the dcdbas interface to the Dell firmware to allow
> the backlight and rfkill interfaces on Dell systems to be driven through the
> standardised sysfs interfaces.
> Signed-off-by: Matthew Garrett <mjg@xxxxxxxxxx>
> ---
> Contains Andrew's suggested updates, plus a fix for a leak on the init
> error path.

I see you don't call rfkill_set_default(). Do Dell firmwares support
persistent rfkill state?

My ill-informed guess is that it shouldn't hurt to call it. If the
firmware is sane, it will initialize the rfkill to a useful state.
Otherwise, the radio(s) would be unusable without the platform driver.
But do feel free to ignore me, if you suspect the firmware of insanity :).

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at