Re: [PATCH] ext3: also fix loop in do_split()

From: Eric Sandeen
Date: Tue Dec 02 2008 - 15:36:38 EST

Andrew Morton wrote:

> A local variable called `i' should always have signed type. In fact,
> it should have `int' type. Doing
> unsigned i;
> is an act of insane vandalism, punishable by spending five additional
> years coding in fortran.
> I suggest you fix this by giving `i' the type God intended, or by
> making it unsigned and then renaming it to something which is not
> intended to trick programmers and reviewers.
> Sheesh.

/me hangs head in shame, and points feebly but only halfheartedly at the
other people who reviewed the change when it originally went in... I
have no idea what I was thinking. Sorry. Please don't make me go back
to Fortran.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at