Re: [PATCH 1/1] edac x38: new MC driver module

From: Ingo Molnar
Date: Sun Nov 30 2008 - 03:37:38 EST



* Hitoshi Mitake <h.mitake@xxxxxxxxx> wrote:

> On Sat, 29 Nov 2008 19:01:44 +0100
> Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
>
> > I see both rationales and you combine them in your patch - OK.
> >
> > And the reason why you cannot just add this to
> > include/linux/io.h is that not all architectures
> > provide a readl()/writel() I assume.
> >
> Yes, I can't say all architectures provide readl/writel.
> And there may be some architecture depended problems,
> so I can't decide to add my readq/writeq as architecture independent ones.
>
> > Feel free to add my Acked-by: to the patch.
>
> Thanks, I added your Acked-by to new patch.

applied to tip/x86/io, thanks! I also did the small cleanup below.

Ingo

------------>