Re: [PATCH] ATM: horizon, fix hrz_probe fail path

From: David Miller
Date: Sat Nov 29 2008 - 23:48:50 EST


From: Jiri Slaby <jirislaby@xxxxxxxxx>
Date: Sat, 29 Nov 2008 22:34:25 +0100

> One fail path in hrz_probe omitted device disable. Fix it.
>
> Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>

Applied, but please post all networking patches to
netdev@xxxxxxxxxxxxxxx, in particular so that they
get properly tracked at:

http://patchwork.ozlabs.org/project/netdev/list/

I feel like I type this in at least 10 times a day, so
people please start making sure netdev is on the CC: for
all networking patches.

Thanks!

> ---
> drivers/atm/horizon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
> index 6154123..6b969f8 100644
> --- a/drivers/atm/horizon.c
> +++ b/drivers/atm/horizon.c
> @@ -2705,7 +2705,7 @@ static int __devinit hrz_probe(struct pci_dev *pci_dev, const struct pci_device_
>
> /* XXX DEV_LABEL is a guess */
> if (!request_region(iobase, HRZ_IO_EXTENT, DEV_LABEL)) {
> - return -EINVAL;
> + err = -EINVAL;
> goto out_disable;
> }
>
> --
> 1.6.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/