Re: [PATCH] tracing/function-graph-tracer: adjustments of thetrace informations

From: Ingo Molnar
Date: Sat Nov 29 2008 - 09:20:25 EST



* Frédéric Weisbecker <fweisbec@xxxxxxxxx> wrote:

> > Another thing that would be nice is to separate out the "cpu)"
> > printing bits into a helper function. Right now what exists cannot be
> > used in a seq-manner, so i couldnt reuse it.
> >
>
> Isn't it the case with print_graph_cpu() ?

yeah, that should be okay. I didnt use it in verif_pid() because it
returns print_line_t - but i guess it would be better to fix verif_pid()
to check for !ret instead of the ret += thing i added.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/