Re: 2.6.28-rc6-git1 -- BUG: unable to handle kernel paging requestat ffff8800be8b0019

[Andrew Morton]

On Thu, 27 Nov 2008 18:31:34 -0500 (EST) Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> 
> [ Added Frederic ]
> 
> On Thu, 27 Nov 2008, Hugh Dickins wrote:
> >  					break;
> > --- 2.6.28-rc6/include/linux/ftrace.h	2008-11-02 23:17:56.000000000 +0000
> > +++ linux/include/linux/ftrace.h	2008-11-27 16:39:26.000000000 +0000
> > @@ -231,7 +231,7 @@ ftrace_init_module(unsigned long *start,
> >  
> >  struct boot_trace {
> >  	pid_t			caller;
> > -	char			func[KSYM_NAME_LEN];
> > +	char			func[KSYM_SYMBOL_LEN];
> >  	int			result;
> >  	unsigned long long	duration;		/* usecs */
> >  	ktime_t			calltime;
> 
> Acked-by: Steven Rostedt <srostedt@xxxxxxxxxx>
> 
> The boot tracer was written by Frederic.
> 

This makes rather a mess when applied ahead of the (massive) ftrace
changes in linux-next.

afacit these two func[] arrays:

--- /dev/null
+++ b/include/trace/boot.h
@@ -0,0 +1,56 @@
+#ifndef _LINUX_TRACE_BOOT_H
+#define _LINUX_TRACE_BOOT_H
+
+/*
+ * Structure which defines the trace of an initcall
+ * while it is called.
+ * You don't have to fill the func field since it is
+ * only used internally by the tracer.
+ */
+struct boot_trace_call {
+	pid_t			caller;
+	char			func[KSYM_NAME_LEN];
+};
+
+/*
+ * Structure which defines the trace of an initcall
+ * while it returns.
+ */
+struct boot_trace_ret {
+	char			func[KSYM_NAME_LEN];
+	int				result;
+	unsigned long long	duration;		/* nsecs */
+};


will need to be changed to KSYM_SYMBOL_LEN.  I think.  Please fix it up
carefully when this all lands on your doorstep.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/