Re: [PATCH] tracing/function-graph-tracer: adjustments of the trace informations

[Frédéric Weisbecker]

2008/11/28 Ingo Molnar <mingo@xxxxxxx>:
>
> another thing which i'm sure you are aware of:
>
> # tracer: function_graph
> #
> #           TASK-PID    CPU#    TIMESTAMP  FUNCTION
> #              | |       |          |         |
>  ------------------------------------------
>  | 1)  S99local--1  =>  ssh-1724
>  ------------------------------------------
>
>  1)      0.867 us |        }
>  1)               |        mark_page_accessed() {
>  1)      0.293 us |          constant_test_bit();
>  1)      0.294 us |          constant_test_bit();
> [...]
>
> the header description is now out of of sync :-)
>
> Also, we should probably not start the trace with a PID-switch event.
> the last_pid[] markers are probably out of sync when we start printing
> the trace.
>
> So the output should probably be something like:
>
> # tracer: function_graph
> #
> # CPU      COST     FUNCTION-GRAPH
> # |          |       |
>
>  1)      0.867 us |        }
>  1)               |        mark_page_accessed() {
>  1)      0.293 us |          constant_test_bit();
>  1)      0.294 us |          constant_test_bit();
> [...]


Ok I will just have to update something in the open callback....
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/