Re: [PATCH -v3 8/8] dnotify: reimplement dnotify using fsnotify

[Al Viro]

On Tue, Nov 25, 2008 at 12:21:33PM -0500, Eric Paris wrote:

> +	.mark_clear_inode = clear_mark_dir_notify,

... called under a spinlock

> +static void clear_mark_dir_notify(struct fsnotify_mark_entry *entry, struct inode *inode, unsigned long mask __attribute__ ((unused)), unsigned int flags)
> +{
...
> +	fsnotify_put_group(dnotify_group);

... which grabs a mutex.

Incidentally, why the hell do you bother with refcounting on groups here?
dnotify is not something that's going to be unloaded, for fsck sake...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/