Re: [PATCH v3] relatime: Make relatime smarter

[Christoph Hellwig]

On Thu, Nov 27, 2008 at 04:59:29PM +0000, Matthew Garrett wrote:
> Make relatime smarter
>     
> Allow atime to be updated once per day even with relatime. This lets
> utilities like tmpreaper (which delete files based on last access time)
> continue working. The time between atime updates can be configured at boot
> with the relatime_interval kernel argument, or at runtime through /proc

Technically it's sysctl which just happens to be exposed in /proc..

> +	if (mnt->mnt_flags & MNT_RELATIME)
> +		if (!relatime_need_update(inode, now))
> +			goto out;
>  	if (timespec_equal(&inode->i_atime, &now))

Maybe rename relatime_need_update to atime_need_update and factor
this check into it?

Except for this nitpicks this seems extremly useful
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/