[PATCH] [PPPOL2TP] Add missing sock_put() in pppol2tp_release()

[FrÃdÃric Moulins]

pppol2tp_sock_to_session() do sock_hold() if the session to release is
not NULL.

Signed-off-by: FrÃdÃric Moulins <frederic.moulins@xxxxxxxxxxx>
---
Patch is applicable to kernels 2.6.26 and following.

Tested with a 2.6.26 stable kernel:
without this patch, a session in a persistent tunnel cannot be
established again (connect failed: -17), and the pppol2tp kernel module
cannot be removed because still considered in use after stopping all
userspace daemons.

diff --git a/drivers/net/pppol2tp.c b/drivers/net/pppol2tp.c
index ff175e8..de80ba4 100644
--- a/drivers/net/pppol2tp.c
+++ b/drivers/net/pppol2tp.c
@@ -1353,6 +1353,7 @@ static int pppol2tp_release(struct socket *sock)
 			kfree_skb(skb);
 			sock_put(sk);
 		}
+		sock_put(sk);
 	}
 
 	release_sock(sk);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/