Re: [PATCH -v3 5/8] fsnotify: unified filesystem notificationbackend

[Peter Zijlstra]

On Tue, 2008-11-25 at 12:21 -0500, Eric Paris wrote:
> +
> +void fsnotify_put_group(struct fsnotify_group *group)
> +{
> +       mutex_lock(&fsnotify_grp_mutex);
> +       if (atomic_dec_and_test(&group->refcnt)) {
> +               list_del_rcu(&group->group_list);
> +               mutex_unlock(&fsnotify_grp_mutex);
> +
> +               synchronize_srcu(&fsnotify_grp_srcu_struct);
> +
> +               fsnotify_recalc_global_mask();
> +               fsnotify_kill_group(group);
> +
> +               return;
> +       }
> +       mutex_unlock(&fsnotify_grp_mutex);
> +
> +       return;
> +}

do you really need that mutex in the ! case?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/