Re: [patch 05/24] perfmon: X86 generic code (x86)

From: Thomas Gleixner
Date: Thu Nov 27 2008 - 09:41:44 EST


On Thu, 27 Nov 2008, David Miller wrote:
> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > __attribute__ ((packed)); ???
>
> Shouldn't be needed and this woule kill performance on RISC (every
> struct member is accessed with byte sized loads and shifts/masking).
>
> We did this for the pfkey.h structures by accident, and I truly regret
> it.

Fair enough.

Thanks,

tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/