Re: [patch 05/24] perfmon: X86 generic code (x86)

From: Thomas Gleixner
Date: Thu Nov 27 2008 - 06:50:33 EST


On Thu, 27 Nov 2008, David Miller wrote:

> From: "stephane eranian" <eranian@xxxxxxxxxxxxxx>
> Date: Thu, 27 Nov 2008 12:35:54 +0100
>
> > I am still wondering how Oprofile handles the case where multiple
> > processes or threads access the same file descriptor.
>
> There's only one profiling buffer active on a given cpu,
> so it's pure per-cpu value insertion.
>
> In any event I think that NMI profiling is a must, especially
> for the kernel. You get total unusable crap otherwise. I
> just learned this the hard way having gotten an NMI'ish scheme
> working on sparc64 just the other day.

Not arguing about that, I'm just not agreeing with the implementation.

So for the moment we can go w/o the NMI and implement it cleanly after
we got the initial lot in.

Thanks,

tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/