Re: [PATCH 2/2] relatime: Allow making relatime the default behaviour

From: Matthew Wilcox
Date: Wed Nov 26 2008 - 16:11:52 EST


On Wed, Nov 26, 2008 at 07:58:24PM +0000, Matthew Garrett wrote:
> +#define MS_NORELATIME (1<<24) /* Disable relatie even if the default */

typo

Otherwise, looks good.

Reviewed-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>

Instead of using __setup, could we use core_param() for these two
parameters? I'm not sure that core_param are exposed in /sys or /proc
anywhere ... if we could fix that, I think it'd simplify this patch
enormously.

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/