Re: [PATCH] ricoh_mmc: Handle newer models of Ricoh controllers

[Pierre Ossman]

On Wed, 26 Nov 2008 06:42:20 -0800
Philip Langdale <philipl@xxxxxxxxx> wrote:

> Frans Pop wrote:
> >> The latest generation of laptops are shipping with a newer
> >> model of Ricoh chip where the firewire controller is the
> >> primary PCI function but a cardbus controller is also present.
> > 
> > Note that the current separate ricoh_mmc disabling module approach has 
> > been shown to break during suspend/resume. Matthew Garret proposed a 
> > patch for that which (with minor fixups) I tested successfully.
> 
> Hmm. Well, I'm interested as to what Pierre thinks. He explicitly didn't
> want a quirk when we originally looked at the problem and that's why
> ricoh_mmc exists - but maybe this is a good enough reason to revisit that
> decision.
> 

Actually, what I didn't want was a _sdhci_ quirk. I'm fine with a PCI one. In fact,
that's probably the best approach as that register fiddling hides some
PCI devices, so it's best if it is done before enumeration.

(Side note: sdhci has now undergone the architectural change that would
allow a quirk like this, but the PCI version is probably still best)

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

Attachment: signature.asc
Description: PGP signature