Re: [patch 20/24] perfmon: system calls interface

[Ingo Molnar]

another thing:

+static inline int pfm_ctx_permissions(u32 ctx_flags)
+{
+       if (pfm_controls.task_group != PFM_GROUP_PERM_ANY
+                  && !in_group_p(pfm_controls.task_group)) {
+               PFM_DBG("user group not allowed to create a task context");
+               return -EPERM;
+       }
+       return 0;
+}

ctx_flags is unused here. If flags used used later on _then_ should it 
be added to these functions. Right now it just obscures review and 
slows down the code.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/